in reply to Code review on script site
Great idea. Couple comments though:
You mentioned +2 for excessive comments. I'd personally -- for excessive comments. Excessive means that it's more than is needed, which to me means something like:
I think the loop is self commenting enough (not that you'd ever use that). It bothers me when people over comment. You spend more time reading about what each line does than you do reading the program. Maybe something subjective like "effective use of commenting"?#loops through all the lines in a #file and prints them out foreach $line (@file) { print $line; }
Also, I think beyond the cut and dry "points", there should be a human critique on the style, flow, and as always, what could be better.
Just my nickle.
Rich
|
---|
Replies are listed 'Best First'. | |
---|---|
Re: Re: Code review on script site
by Jazz (Curate) on Nov 24, 2001 at 11:23 UTC |
In Section
Meditations