Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Re: Code Critique

by gmax (Abbot)
on Dec 19, 2001 at 16:44 UTC ( #133104=note: print w/replies, xml ) Need Help??


in reply to Code Critique

To be fair, I could download the source code without leaving any e-mail address.
And, indeed, every script says that it is under GPL.

However, one thing that is definitely missing is documentation. By looking at the code itself you can't get the feeling of how things are organized; and the demo can't tell you what's under the hood.
So, I would add some (a lot!) of POD to those scripts.

Finally, one last note. No time to have a look at your code, but, just a shot in the dark. Running:
grep -r "use strict" *
from the root of your snapshot, I get an empty list, meaning that none of your scripts are using it.
The same command inquiring for "-w" and "use CGI" returns a significant list.
gmax

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133104]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (6)
As of 2019-12-06 06:37 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Strict and warnings: which comes first?



    Results (154 votes). Check out past polls.

    Notices?