![]() |
|
Problems? Is your data what you think it is? | |
PerlMonks |
Re: Re: Peruse my code...by Arien (Pilgrim) |
on Aug 31, 2002 at 17:33 UTC ( [id://194358]=note: print w/replies, xml ) | Need Help?? |
These regexes allow for a newline after the last character. This could lead to trouble, for example when assuming your log file consists of one line with fields seperated by commas (as one probably would). The regex for domains assumes all domains are .com, which they are not. Apart from that, it can be written in a more efficient way. Your service regex is flawed: it allows for any string as long as it starts with Yes or ends with No (and optional newline). Also, there's no need to escape a dash (like you do in the email regex) if you put it at the beginning or end of a character class. In summary, I'd write those as:
— Arien
In Section
Seekers of Perl Wisdom
|
|