Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re: Gaim Magic 8 Ball

by dragonchild (Archbishop)
on Sep 16, 2003 at 03:09 UTC ( #291714=note: print w/replies, xml ) Need Help??

in reply to Gaim Magic 8 Ball

my $eb_message=~s/!8ball//g;

That line looks like it's doing nothing useful. Why would you have it there? Also, you return 1; from both execution paths inside the !8ball scenario. Wouldn't it be clearer to remove that from the inner blocks and leave it in the middle block?

Another suggestion would be to reverse your thought process. Instead of figuring out what you need to do to enter a block, figure out what you need to do to continue processing. Possibly done as such:

sub shake_the_ball { my ($eb_connection, $eb_sender, $eb_message, $eb_flags) = @_; return unless $eb_message =~ /!8ball/; my $answer = split(' ', $eb_message) > 1 ? "You need to ask a question!" : "The magic 8 ball says..." . $ball_messages[ rand scalar @ball_m +essages ] . ".\n"; GAIM::serv_send_im($eb_connection, $eb_sender, $answer_message, 1); return 1; }

Take code that's the same except for one variable and combine it so that the variable is assigned, not the code re-written. That improves clarity, reduces bugs, and can often provide a speed boost. (If only in the compile stage ...)

We are the carpenters and bricklayers of the Information Age.

The idea is a little like C++ templates, except not quite so brain-meltingly complicated. -- TheDamian, Exegesis 6

Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://291714]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (6)
As of 2020-11-28 14:05 GMT
Find Nodes?
    Voting Booth?

    No recent polls found