I would change:
# Encrypt file.
my $gpg_command = `gpg --trust-model always -er 12345678 my_file.txt`;
print defined($gpg_command) ? $gpg_command : "Command failed\n";
# Capture STDOUT and save it to a file.
open(READ, "$gpg_command 2>&1 |") or die "Failure on open $!\n";
open( my $out, ">", "encrypted.pgp" ) or die "Could not open file for
+ encrypted data - $!";
to:
# Build encryption command
my $gpg_command = "gpg --trust-model always -er 12345678 my_file.txt";
# Execute command and capture STDOUT.
my $gpg_results = `$gpg_command`;
print defined($gpg_results) ? $gpg_results : "Command failed\n";
# Save captured STDOUT to a file.
open( my $out, ">", "encrypted.pgp" ) or die "Could not open file for
+encrypted data - $!";
Then:
- Correct any errant assumptions about what happens when the command fails;
- Adjust what you're writing to the output file to reflect what you actually want there.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|