One brief comment - Always use the 2 argument form of bless,
bless($self,$class);
so that the class can be subclassed. You may need to check the
$class, depending on how it is called, so
my $proto = shift;
my $class = ref($proto) || $proto;
# stuff to create self
bless($self,$class);
is good practice. bless returns the item as well, so you could write
your new() method as
sub new
{
my ($proto,$name,$type,$end) = @_;
my $class = ref($proto) || $proto;
return bless
{
name => $name,
type => $type,
end => $end,
attributes => {},
}, $class;
}
--
Brovnik
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.