I'm using qx to ssh several admin commands on remote servers. I know I should be using Net::SSH, but the machines involved are legacy. And by legacy, I mean so ancient that we can't install, update, or patch either the OS or anything else.
I really appreciate any time you can spare to sanity check this script. It's currently running and getting the job done, but if you could let me know if I'm doing anything dangerous or if there's a better and/or more stable way of doing it, that would be wonderful.
#!/usr/bin/perl
use strict;
use warnings;
use Data::Dumper;
use File::Basename qw(basename);
#use Net::OpenSSH;
sub ops_do_ssh_qx {
my ($cmd) = @_;
$cmd->{ssh_cmd} = 'ssh ' . $cmd->{user} . '\@' . $cmd->{host} . '
+\'' . $cmd->{command} . '\'' . ' 2>/dev/null';
$cmd->{output} = qx($cmd->{ssh_cmd});
if ( defined $cmd->{output} ) {
$cmd->{cmd_ret_code} = $?;
chomp $cmd->{output};
}
else {
($cmd->{ssh_ret_code}, $cmd->{ssh_ret_msg}) = (0 + $!, '' . $!);
}
return $cmd;
}
my $state = {
progname => basename($0),
status => 'success'
};
my @commands = (
{ name => 'command_name1',
user => 'user1',
host => 'server1.foo.com',
command => 'rsync_command yadda yadda'
},
{ name => 'command_name2',
user => 'user2',
host => 'server2.foo.com',
command => 'rsync_command yadda yadda'
}
);
for my $cmd (@commands) {
if ($state->{status} eq 'success') {
my $cmd_status = ops_do_ssh_qx($cmd);
if ( (!defined $cmd_status->{cmd_ret_code}) or ($cmd_status->{cm
+d_ret_code} != 0) ) {
$state->{status} = 'failure';
$state->{stack_trace} = $cmd_status;
}
}
}
if ($state->{status} ne 'success') {
$Data::Dumper::Varname = $state->{progname} . '_state_';
print Dumper($state);
exit 1;
}
Thanks,
cbeckley
Update: I meant Net::OpenSSH rather than Net::SSH
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|