I see that you're fetching categories in groups, grabbing all the children of a specific category, then going on to the next parent category... My inclination would be to fetch all the categories at once, then organize them. Here's one way to do this:
my $cats_sth = $dbh->prepare(<<"EndOfSQL");
SELECT category_id, name, parent
FROM $sql{categories}
ORDER BY category_id ASC
-- assumes parent id is always less than child id
EndOfSQL
my @cats;
# build the data structure
while (my($cat_id, $name, $parent_id) = $cats_sth->fetchrow_array()) {
$cats[$cat_id] = [$name, $parent_id, []];
if ($cats[$parent_id]) {
push @{$cats[$parent_id][2]}, $cat_id;
} elsif ($parent_id) {
warn "Parent $parent_id not found for category $cat_id '$name'
+\n";
}
}
# print the categories
foreach my $cat (@cats) {
next unless $cat and !$cat->[1];
print_category($cat, \@cats, '');
}
# recursively print a category and its children
sub print_category {
my($cat, $cats, $indent) = @_;
print $indent, $cat->[0], "\n";
foreach my $child_id (@{$cat->[2]}) {
print_category($cats->[$child_id], $cats, "$indent ");
}
}
The data structure that this uses is:
[
[ name, parent id, [ child ids ] ],
[ name, parent id, [ child ids ] ],
...
]
where the ids are also the indexes into the array.
This probably is not the best data structure for your task, although it does get the job done. It should give you some ideas about solving the problem.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.