use base Vehicle;
@ISA = 'Vehicle';
Pick one or the other, not both. I prefer base.
croak "$option is not valid" if ! $self->_valid( $option );
Use unless.
my %valid = map { $_ => 1 } qw( Wheels Doors Color Passengers );
my %ro = map { $_ => 1 } qw( Wheels );
sub _read_only {
my ($self, $option) = @_;
return defined $ro{$option} ? 1 : 0;
}
If you elided the lexicals in favor of class methods, you wouldn't have to repeat this code in both subclasses:
sub _attributes
{
return
{
map { $_ => 1 } qw( Wheels Doors Color Passengers )
};
}
sub _valid
{
my ($self, $attribute) = @_;
return exists $self->_attributes()->{ $attribute };
}
Finally, aside from inheriting a constructor and an AUTOLOAD, I don't see any reason why you need to inherit here. You'd probably be better off using a module that autogenerated your accessors. It's not wrong, but I don't see any real benefits to this approach.
I did it this way when I was first learning, though. It won't cause you any real trouble; it's just a bit more complication that doesn't add very much. ~shrug~
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.