I certainly see this in Perl all the time:
$self->total( $self->total + 1 );
Before automatically writing this off as being bad code, consider:
- The class has--or appears to have--a public accessor and a public mutator for total.
- The mutator is free to do stuff other than setting total. For example, it might log that fact that total has changed, or it might notify other agents who have registered interest in that aspect of the the instance.
- Subclasses are free to add interesting behavior to mutations of total, even if those mutations are generated internal to the class.
By coding this as
$self->{total}++;
you lose these benefits. Sometimes these benefits aren't important, sometimes they're vital. That said, perhaps
$self->increment_total;
might have been better.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|