Looks good to me too (but that's not saying that much!)
If a print statement is a bit unwieldy I often use join to get it to read better.
print join "\n",
'<center>',
'<h3>MSHIP - my status of host IP's</h3>',
'</center>';
I would have considered $ping instead of $p.
I prefer a space either side of an = (sometimes you do too, sometimes you don't!).
I think that 2 space tabs use less real estate than 4 if there is deep nesting.
foreach $_(@TMP)
could be written as
for (@TMP)
} else {
Is that what they call cuddled?
It's controversial but I put the else on a new line.
All very minor.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|