Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
I am not sure why the code terminates, however I do have a comment about your code.

You open a handle to the log file each time you process a host from your @hostnames array. Perhaps you could look at opening the file handle once before processing the entire array. Also you may want to only sleep after the foreach...

Something like

use strict; use Time::Local; use Net::Ping; my ($time); my @hostnames = ("", ""); my $p = Net::Ping->new("icmp"); my $hostname; print "\nWriting data to ping.log\n"; print "Press CTRL-C to exit\n"; while(1) { open (LogFile, ">>ping.log") || die "Sorry, cannot open logfile\n" +; foreach my $hostname (@hostnames) { $time = localtime; print (LogFile "$time - "); print (LogFile "$hostname is "); print (LogFile "NOT ") unless $p->ping($hostname, 2); print (LogFile "reachable.\n"); } close Logfile; sleep(5); }

These changes will not affect you unless you @hostnames array grows to more than 1 host though.

Of all the things I've lost in my life, its my mind I miss the most.

In reply to Re: Ping log terminates unexpectedly by AcidHawk
in thread Ping log terminates unexpectedly by Scrat

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or or How to display code and escape characters are good places to start.
Log In?

What's my password?
Create A New User
Domain Nodelet?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others perusing the Monastery: (4)
As of 2021-09-25 01:45 GMT
Find Nodes?
    Voting Booth?

    No recent polls found