Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

Hey, happy to help. But my helping you is not done yet. ;}

Program stops after printing "bad event type" message .. .

bad event type or keysym "_" at PMEdit-001.000202-1.pl line 269, <DATA +> line 81.
... but that goes away (and a Tk window emerges) if I change _ to one of [a-zA-Z0-9] but not [-+].

Other minor problems ... (1) chomp fails to clear ^M in __DATA__ ...

1057 sub LoadConfig { 1058 my $ok = 1; 1059 1060 while (<DATA>) { 1061 # Load the default configuration stuff 1062 chomp; 1063 next if ! length; ... 1067 my ($tag, $htmlTag, $name, $flagsField, @options) = split + /\s*,\s*/; 1068 1069 if (! defined $flagsField) { 1070 print "Missing entries in tag line ($.): $_"; ...
... which causes above print() to act; line numbers reported are 32 & 58.

(2) Later in LoadConfig(), chomp() is rendered useless by use of s/\s+$//; ...

1136 while (<DATA>) { 1137 # Load key binding information 1138 next if /^#/; 1139 1140 chomp; 1141 s/^\s+//; 1142 s/\s+$//;
In both cases, I suggest just use s/\s+$// & chop the chomp().

(3) There seems to spurious tab characters on lines 228, 769, 771-772, 774-775.

diff -u output follows ...

--- PMEdit-001.000202-1.pl--ORIG Fri Dec 1 00:57:17 2006 +++ PMEdit-001.000202-1.pl Fri Dec 1 02:44:20 2006 @@ -225,7 +225,7 @@ my %commands = ( selAll => \&do_selAll, copy => \&do_copy, - paste => \&do_paste, + paste => \&do_paste, ); my $realText = $text->Subwidget ('scrolled'); @@ -766,13 +766,13 @@ sub about { my $versions = ''; for (@usedModules) { - my $name = $_->[1]; + my $name = $_->[1]; - $name =~ s/\..*//; - $name =~ s|[\\/]|::|g; + $name =~ s/\..*//; + $name =~ s|[\\/]|::|g; - my $version = $name->VERSION; - $versions .= "$name \t$version\n" if defined $version; + my $version = $name->VERSION; + $versions .= "$name \t$version\n" if defined $version; } my $msg = <<"MSG"; @@ -1059,7 +1059,7 @@ while (<DATA>) { # Load the default configuration stuff - chomp; + s/\s+$//; next if ! length; last if /^#key /; next if /^#/; @@ -1136,11 +1136,10 @@ while (<DATA>) { # Load key binding information next if /^#/; - - chomp; + s/^\s+//; s/\s+$//; - + next if ! length; my ($tag, $key, $menuItem, $toolbarItem, $rightClickItem) = s +plit /\s*,\s*/; @@ -1239,7 +1238,7 @@ strike,Control s,Format/Strike out,,Strike out sub,Control u,Format/Subscript,,Subscript super,Control s,Format/Superscript,,Superscript -underline,Control _,Format/Underline,,Underline +underline,Control 9,Format/Underline,,Underline -,-,Format/-,-, code,Control k,Format/Code,,Code quote,Control q,Format/Blockquote,,Blockquote @@ -1247,4 +1246,4 @@ #links - still bindings cpan,,Links/CPAN,,CPAN link id,Control d,Links/Node,,Node id link -name,Control n,Links/Name,,Node name link \ No newline at end of file +name,Control n,Links/Name,,Node name link


In reply to Re^4: PerlMonks Editor by parv
in thread PerlMonks Editor by GrandFather

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others contemplating the Monastery: (4)
    As of 2020-01-22 01:35 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?
      Notices?