A couple things:
- If you aren't woried about error results of mkdir (maybe you should be, but you aren't checking right now), you don't need to check if the directory exists. If it exists, the function returns an error (which you don't check, so to you it won't make a difference).
- the File::Path core module contains a nice function called mkpath which recursively checks parent dirs to make sure they exist before making the directory of interest
- Long path values should be kept in a constant or a variable somewhere
- if(! ...) is better written as unless( ... ), this is more of a personal style thing, but at least use if (not ... ) as both are more readable
Here's how I'd do it:
use File::Path 'mkpath';
use constant DIR => 'e:/web/public_html/eagle_f91...';
unless (-d DIR) {
mkpath(DIR) or die "Could not mkpath: $!\n"
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|