This is not critism. Style is a very subjective thing, and more people are likely to adhere more closely to yours than mine.
But ... what advantages do you see for your program over this which I believe to be roughly functionally equivalent? :
#! perl -slw
use strict;
use List::Util qw[ shuffle ];
our( $L, $N, $S, $h, $p );
our $l //= 14;
if( $h ) {
print "$0 [-L -N -S -p -l=nn -h]\n", <DATA>;
exit;
}
$l = $l <= 0 ? 14 : $l > 100 ? 100 : $l;
my @chars;
push @chars, 'a'..'z', 'A'..'Z' unless $L;
push @chars, 0 .. 9 unless $N;
push @chars,
split'', q[`~!@#$%^&*()_+-=\,./<>?;':"[]{}] #'
unless $S;
printf "%s%s\n",
$p ? '' : 'Password: ',
join'', (shuffle @chars)[ 0 .. $l-1 ];
__DATA__
-h this help
-p supress "Password:"
-l=nn length to generate: 1 .. 100; default:14
-L supress letters (upper and lower)
-N supress digits
-S supress symbols `~!@#$%^&*()_+-=\,./<>?;':"[]{}
And which do you find easier to follow?
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.