I am parsing a string and would like to make conditional decisions based on data the stings contains. Could you guys tell me how effective this code is in doing that and if there is a better way I would certainly appreciate knowing that too.
I want to keep the code as easy to read and maintain as possible too.
if(!defined($mystring)){
dosumpton("nogames",undef,undef,undef);
} elsif ($mystring){
($major,$minor,$bld,$rev) = split(/\./, $mystring);
if($major){
if($minor){
if($bld){
if($rev){
dosumpton($major,$minor,$bld,$rev);
} else {
dosumpton($major,$minor,$bld,undef);
}
} else {
dosumpton($major,$minor,undef,undef);
}
} else {
dosumpton($major,undef,undef,undef);
}
}
} else {
# Something went wrong and we should be notified about it
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.