Re: SNMP - cont

[davido]

You've got a lot of scoping problems. The clues others have provided are definately on target, but the problem is that you've got more than one problem. Don't discount their remarks until you've hunted down each and every time that you're declaring the same variable multiple times. You can't just pepper a script with 'my' until strict stops complaining. You have to pay attention to the scope in which variables are declared, and to whether or not one declaration is masking another at broader scope.

First, if you are declaring @test1 at a fairly broad scope to be accessible several places thoughout the script, then when you re-declare it at narrower scope and assign to it, that declaration masks the previous. You are ok assigning to it in that narrower scope, but the effects of the assignment vanish when the narrower scope ends. The culprit is this line: my @test1 = @serial;. If anything, it should be @test1=@serial;, so that the assignment is to the outter @test1, not the inner @test1 (these are two different variables, since you declared them twice at different scopes).

Later, in an entirely different lexical block you're saying, "print my @test1;". How many times are you going to declare @test1? Because this is the third time, and consequently, a third @test1 (completely unrelated to the other two). It lives in its own lexical scope, and that masks any other @test1's declared at broader lexical scope.

Ok, those are the most glaring scoping issues. But they're biggies. Don't just throw 'my' around like that. Declare a variable in the narrowest scope you can get away with, so long as that scope permits the variable to be accessible to all the code that needs it. You're declaring it once in that nice broad scope, but then two more times in narrower scope. The outter @test1 is never receiving a value, and never printing a value. The first inner @test1 is reeiving a value but then it falls out of scope and is lost forever. The secind inner @test1 is being printed, but it never received a value. That's what 'my' is doing for you.

Next, don't place calls to the operating system without checking to see that they worked. That means, you should always check for failure in your opens. And if the filehandle is opened for output, check for success in your closes too. See perlopentut for details on that. Even your initialization of Net::SNMP->session() should have its return value checked for success. Otherwise, you'll just never be sure at what point the script is failing.

[theroninwins]

Thanks for that helüp, I now understand better what it is all about... I changed the code to the following:



#!/usr/bin/perl -w

use Net::SNMP;
use strict;
use warnings;
use diagnostics;
                                                                      
          
open IPFILE, "ipfile.txt" or die "Can't get IPs - $!\n";

    

                                                                      
          
my $community = 'public';
my $ifIndex   = '1.3.6.1.2.1.47.1.1.1.1.6';  #1.3.6.1.2.1.2.2.1.1     
+ 1.3.6.1.2.1.47.1.1.1.1.12
my $ifDescr   = '1.3.6.1.2.1.47.1.1.1.1.11';  #1.3.6.1.2.1.47.1.1.1.1.
+13
my $ifDescr2   = '1.3.6.1.2.1.47.1.1.1.1.2';  #1.3.6.1.2.1.47.1.1.1.1.
+13


my @serial;

my @test2;
          
while ( my $ip = <IPFILE> )
{
    chomp $ip;
    print "Got: $ip\n";                                               
+                   

    my ( $session, $error ) = Net::SNMP->session(
        -hostname  => $ip,
        -community => $community,
        -port      => 161
    );
    my $response;
                                                                      

    if ( defined( $response = $session->get_table($ifIndex) ) )
    {
        foreach my $index ( values  %{$response} ) #values
        {
        my $this_desc = "$ifDescr.$index";
            my $description;
            if ( defined( $description = $session->get_request($this_d
+esc) ) )
            {
           @serial = values %{$description};
           
          #print @serial;
    
        }
        }
        foreach my $index ( values  %{$response} ) #values
        {
        my $this_desc = "$ifDescr2.$index";
            my $description2;
            if ( defined( $description2 = $session->get_request($this_
+desc) ) )
            {
            my @desc = values %{$description2};
            #open OUT, ">>desclist.txt";
            #print OUT @desc;
            #close OUT;
            #open (FILE, ">>desclist.txt");
            #print keys %{$description};
            #print '.......';
            #print values %{$description2}, "\n";
            }
               
       
    }   
    
    print @serial;
    

    }
    
    $session->close();

}



however the problem is still the same for some reason I really don't get it yet. From my understanding it should be ok when i declare a Var once with my and then i can use it as a global var when i use the same var without the my infront of it . So this should be weorking. When i print the @serial within the same part i assign a value to it it does but like this is doesn't.

[theroninwins]

Ok I got it going somehow, now it uses temp files but it works :-) Here it is my first prog :-).



#!/usr/bin/perl -w

use Net::SNMP;
#use strict;
use warnings;
use diagnostics;
                                                                      
          
open IPFILE, "ipfile.txt" or die "Can't get IPs - $!\n";

    

                                                                      
          
my $community = 'public';
my $ifIndex   = '1.3.6.1.2.1.47.1.1.1.1.6';  #1.3.6.1.2.1.2.2.1.1     
+ 1.3.6.1.2.1.47.1.1.1.1.12
my $ifDescr   = '1.3.6.1.2.1.47.1.1.1.1.11';  #1.3.6.1.2.1.47.1.1.1.1.
+13
my $ifDescr2   = '1.3.6.1.2.1.47.1.1.1.1.2';  #1.3.6.1.2.1.47.1.1.1.1.
+13



          
while ( my $ip = <IPFILE> )
{
    chomp $ip;
    print "Got: $ip\n";                                               
+                   

    my ( $session, $error ) = Net::SNMP->session(
        -hostname  => $ip,
        -community => $community,
        -port      => 161
    );
    my $response;
                                                                      

    if ( defined( $response = $session->get_table($ifIndex) ) )
    {
        foreach my $index ( values  %{$response} ) #values
        {
        my $this_desc = "$ifDescr.$index";
            my $description;
            if ( defined( $description = $session->get_request($this_d
+esc) ) )
            {
           
            my @serial = values %{$description};
          open OUTPUT1, ">>serlist.txt";
          print OUTPUT1 @serial, "\n";
          close OUTPUT1;
    
        }
        }
        foreach my $index ( values  %{$response} ) #values
        {
        my $this_desc = "$ifDescr2.$index";
            my $description2;
            if ( defined( $description2 = $session->get_request($this_
+desc) ) )
            {
            my @desc = values %{$description2};
            open OUTPUT2, ">>desclist.txt";
            print OUTPUT2 @desc, "\n";
            close OUTPUT2;
           
            }
               
       
    }   
    
    
    open(OUT, "serlist.txt");
    open(OUT2, "desclist.txt");
    my @outlist;
    while (<OUT>)
        {
        my %hash;
        my @temp = split(/;/,$_);
        $hash{'file1'} = $temp[0];
        $hash{'file2'} = <OUT2>;
        
        #Return entfernen
        foreach (values %hash)
            {
            $_ =~ s/\n//g;
            }
        push(@outlist,\%hash);
        }
    close(OUT);


    open FINOUT, ">>finallist.txt";
    print FINOUT "$ip\n"; 
    foreach my $hashref (@outlist)
    {
        print FINOUT "$hashref->{'file1'};$hashref->{'file2'}\n";
    }
    print FINOUT "\n";    
    close FINOUT;
    }
    
    $session->close();
}



... maybe you have an idea to do it without those temps.

[theroninwins]

OK thanks for all of your help everyone and here it is the work I made all the tmie:


#!/usr/bin/perl -w

#############################################################
#This program generates a list of informations by parsing an#
#xml file and then extrating the informations via SNMP,     #
#saving the result in a textfile.                #
#Ver:1.0    written by:ronin            #
#############################################################


use Net::SNMP;
use strict;
use warnings;
use diagnostics;
use XML::Simple;
use Data::Dumper;



######################################################################
+############
#This part of the program generates an IP file with one ip address per
+ line.     #
#It reads the IPAddress tagged information from the xml file it parses
+.          #
#The IP addresses are then saved in a txt file.                       
+        #
#The information saved here are later used and referred to as ipfile.t
+xt      #
#Ver:1.0    written by :ronin                      #
######################################################################
+############

#open xml file
my $xmlfile = $ARGV[0];



my $ref = eval { XMLin($xmlfile) };


#erase or creat the ipfile
open ERASER, ">ipfile.txt";
close ERASE;

#see if open worked
if ($@)
{
    print "XML Read ERROR";
 } 
     else 
         {        
        #go to IPAddress tag and read infos into file
        foreach my $item (@{$ref->{Layer2Details}->{Device}}){
            
            my @ipliste = $item->{IPAddress};
                
            my @sorted = @ipliste;
            open OUTIP, ">>ipfile.txt";
            print OUTIP @sorted, "\n";
            close OUTIP;
        }
}



####################################################################
#The second part of the porgram uses the above saved IP addresses  #
#reading them from the file and looping for as many times as       #
#necessary. It gets all informations from manually added MIB knots #
#and saves these informations in seperate files. Then it parses all#
#files and generates a full unedited listing saving it in another  #
#file. This unedited file is then reopened and edited so that only #
#the wanted usefull informations remains. The final file is then   #
#saved (in Ver 1.0 as finallist.txt).                     #
#Ver:1.0    written by: ronin               #
####################################################################


 
#open ipfile
open IPFILE, "ipfile.txt" or die "Can't get IPs - $!\n";

    

                                                                      
#Sets knots und community          
my $community = 'public';
my $ifIndex   = '1.3.6.1.2.1.47.1.1.1.1.6';  
my $ifDescr   = '1.3.6.1.2.1.47.1.1.1.1.11'; 
my $ifDescr2   = '1.3.6.1.2.1.47.1.1.1.1.2';  


#erase or create files
open ERASER, ">serlist.txt";
close ERASE;
open ERASER, ">desclist.txt";
close ERASE;
open ERASER, ">alllist.txt";
close ERASE;
open ERASER, ">finallist.txt";
close ERASE;

#looping as long as there are IP addersses
while ( my $ip = <IPFILE> )
{
    chomp $ip;
    print "Got: $ip\n";                                               
+                   

    #open session
        my ( $session, $error ) = Net::SNMP->session(
        -hostname  => $ip,
        -community => $community,
        -port      => 161
    );
    my $response;
                                                                      
    #goto index table and hash index
    if ( defined( $response = $session->get_table($ifIndex) ) )
    {
       
       
    #get serialnumbers
        foreach my $index ( values  %{$response} ) 
        {
        my $this_desc = "$ifDescr.$index";
            my $description;
            if ( defined( $description = $session->get_request($this_d
+esc) ) )
            {
           
          #print serialno. to file
          my @serial = values %{$description};
          open OUTPUT1, ">>serlist.txt";
          print OUTPUT1 @serial, "\n";
          close OUTPUT1;
    
        }
        }


    #get description
        foreach my $index ( values  %{$response} ) 
        {
        my $this_desc = "$ifDescr2.$index";
            my $description2;
            if ( defined( $description2 = $session->get_request($this_
+desc) ) )
            {


            #print describtion to file
            my @desc = values %{$description2};
            open OUTPUT2, ">>desclist.txt";
            print OUTPUT2 @desc, "\n";
            close OUTPUT2;
           
            }
               
       
    }   
    
        #create final file
    open(OUT, "serlist.txt");
    open(OUT2, "desclist.txt");
    my @outlist;
    while (<OUT>)
        {
        my %hash;
        my @temp = split(/;/,$_);
        $hash{'file1'} = $temp[0];
        $hash{'file2'} = <OUT2>;
        
        #delete Return
        foreach (values %hash)
            {
            $_ =~ s/\n//g;
            }
        push(@outlist,\%hash);
        }
    close(OUT);

    #print to file
    open ALLOUT, ">>alllist.txt";
    print ALLOUT "$ip\n"; 
    foreach my $hashref (@outlist)
    {
        print ALLOUT "$hashref->{'file1'};$hashref->{'file2'}\n";
    }
    
    close ALLOUT;


    #scanning the file for useless lines and deleting them and then
    #saving the rest in a new file
    open SCAN, "<alllist.txt";
    my @data = grep { /^\S+;/ } <SCAN>;
    open FINOUT, ">>finallist.txt";
    print FINOUT @data, "\n";
    close SCAN;
    }
    
    #close session
    $session->close();
}


It reads all IPAddress-tagged infos from an xml file andf then uses those to get infos from MIBs via SNMP, saves thjem in different files and then creats another file with the result in a certain order like a csv file so it can be automatically read be progrags like CiscoWorks 2000. Thanks again everybody for the help provided.