Re: Critique/Test my first module MetaParser

[tachyon]

Your parsing is very broken. You are making a whole load of invalid assumptions about the structure of a meta tag. You don't have to look very far for common examples of HTML syntax that breaks your parser. Perlmonks for example has meta tags. Your code does not extract them...... Please learn to use HTML::Parser or learn a lot more about what is and is not valid HTML.

use LWP::Simple;
use HTML::Parser;
use Data::Dumper;

my $data = get('http://www.spydersubmission.com');

my $p = HTML::Parser->new(
    api_version => 3, 
    start_h     => [ \&start, "self,tagname,attr" ],
);
sub start {
    my ( $self, $tagname, $attr ) = @_;
    return unless $tagname eq 'meta';
    my $name = $attr->{name} || $attr->{'http-equiv'} || undef;
    return unless defined $name;
    $self->{meta}->{$name} = $attr->{content} || 'NULL';
}
$p->parse($data);
$p->eof;

print Dumper $p->{meta};