in reply to Hacking perl

Superb write up.

I feel sadend however, by one thing that seems to be missing, but in my opinion is absolutely critical to any patch to any OSS Code Base -- test cases.

Even if you don't believe in Test driven development, even if you don't worry about having 100% code coverage in your test suite, the best way to explain what a patch does, is to provide some tests that demonstrates it's usage.

Replies are listed 'Best First'.
Re^2: Hacking perl
by robin (Chaplain) on Oct 21, 2005 at 07:13 UTC

    A very good point, thanks. (Certainly a patch would never be accepted into the core unless accompanied by tests.) I'll update my node to include some tests.

    Update: I've updated it. Now with tests!