Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re: Re: Re: using a hash to do substitution?

by tachyon (Chancellor)
on Jun 14, 2001 at 11:02 UTC ( [id://88313]=note: print w/replies, xml ) Need Help??


in reply to Re: Re: using a hash to do substitution?
in thread using a hash to do substitution?

Rather than speculate on efficiency you can always use benchmark. One small point though - whenever you interpolate a string into a m// regex or the first half of a s/// regex you need to backslash your special regex metacharacters $^*()+{[\|.?

The easiest way is to use quotemeta.

foreach $key (keys %hash) { $key = quotemeta $key; $text =~ s/$key/$hash{$key}/eg; }

This is *vital* for reliability. Otherwise you will get unexpected runtime failures when your data eventually contains metachars (typos, deliberate, malicious...)

use Benchmark; timethese(10000, { 'Simple loop' => ' $text = "This is my test string"; %hash = qw(test text foo bar use loop the end); foreach $key (keys %hash) { $key = quotemeta $key; $text =~ s/$key/$hash{$key}/eg; } ', 'Alternation' => ' $text = "This is my test string"; %hash = qw(test text foo bar use loop the end); $regex = join("|", map(quotemeta, keys %hash)); $text =~ s/\b($regex)\b/$hash{$1}/eg; ', } ); Output: Benchmark: timing 100000 iterations of Alternation, Simple loop... Alternation: 5 wallclock secs ( 4.12 usr + 0.00 sys = 4.12 CPU) @ 2 +4271.84/s (n=100000) Simple loop: 10 wallclock secs ( 9.72 usr + 0.00 sys = 9.72 CPU) @ 1 +0288.07/s (n=100000)

So as it happens alternation is twice as fast. I thought your solution would be faster but there you go!

If in doubt - use Benchmark

Cheers

tachyon

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://88313]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others having an uproarious good time at the Monastery: (3)
As of 2024-07-25 19:08 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?
    erzuuli‥ 🛈The London Perl and Raku Workshop takes place on 26th Oct 2024. If your company depends on Perl, please consider sponsoring and/or attending.