Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Re: Question on style/technique

by VSarkiss (Monsignor)
on Jul 06, 2001 at 05:47 UTC ( #94361=note: print w/replies, xml ) Need Help??

in reply to Question on style/technique

The big question is: Can your program run despite the file open failing? If, for example, you're writing something that digests a log file, and you fail opening the log file, give up the ghost. There's no point in trying to continue. OTOH, if your program can limp along without the file, then just issue a warning and continue. (Continuing the same "digest-a-log-file" example, say you can't open the password file to map UIDs to login names; you can process the log file, although you probably want to tell someone you couldn't open the file. (Contrived example, you get the idea.))

The next question is, what does "issue a warning" mean? That depends very much on the programming shop in which you're running, and whom you want to alert. Don't think in terms of "most elegant", think in terms of "most useful". The appropriate thing may be to write a record in a log file, send an email, or even use CGI::Carp qw(fatalsToBrowser).

Your question also involved using if/else to handle file open errors. This really goes to some programming style issues. I personally despise style guidelines that assert that an if should always "exit at the bottom". To me, code structured like this is a nightmare:

if (open(FH, $file)) { ...complicated logic extending many many lines.... close(FH); } else { warn "Couldn't open $file: $!"\n"; }
because after comprehending the complicated logic in the first block, I have to pop my mental stack and say, "Now who the heck does this else belong to?"

To me, the else block is part of the file opening logic and should be kept together. That is, the code should do something more like this:

unless (open(FH, $file)) { ...send email, sound the klaxons, raise a ruckus, etc. ...if I really can't continue, I'll die or exit here. } else { fun stuff with FH }
The key point about style, IMHO, is to keep all the file open handling logic together.


Replies are listed 'Best First'.
Re: Question on style/technique
by Abigail (Deacon) on Jul 06, 2001 at 06:05 UTC
    There are of course many programs that you do not want to issue any warnings if they cannot open certain files. Lots of application read in various, optional, configuration files, one in the current directory, one in the users home directory, and a system wide config file. Not all config files will exist, or are readable. You want the application to silently skip them. This is very acceptable code:
    foreach my $file (@files) { if (open my $fh => $file) { read in file do whatever you need to do } }

    -- Abigail

      Thanks for the replies everyone, Abigail hit on the mark what i am doing with my code. I often have instances where i just need to grab a bit of data from a file, or append a string, something that can quickly be done in a block and filehandle closed, and something that doesn't necessarily need to happen.. I just didn't know if this might be percieved as "bad coding" practice, since i've never seen it done like that in other's examples.
      Once again, thanks...


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://94361]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (5)
As of 2021-03-08 18:55 GMT
Find Nodes?
    Voting Booth?
    My favorite kind of desktop background is:

    Results (126 votes). Check out past polls.