Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

G'day almsdealer,

Welcome to the Monastery.

Given you're very new to Perl, you've made a great start! Though you're problem has already been solved (by the redoubtable haukex) I'd like to offer a couple of tips to help you on your Perl journey:

  • Always use parens when calling user-defined subroutines (see here for why).
  • Use Perl's core B::Deparse module to see how Perl parses your script.

For example, with your script saved as, running:

perl -MO=Deparse,-p >
allows you to see how Perl parses your script, in your case contains:
use strict; use warnings; sub myTrim { (my($str) = @_); (my($trimmed) = ($str =~ /\s*(.*)\s*/)); (return $trimmed); } (my(@allTags) = ()); foreach my $file (glob('[0-9][0-9][0-9][0-9].txt')) { use File::Glob (); (my(@fileTags) = ()); (open(my $handle, '<', $file) or die(q[couldn't open file])); while (defined((my $line = readline($handle)))) { do { if (($line =~ /^tags/)) { (my($tagsString) = ($line =~ /^tags\s+(.*)/)); (@fileTags = (@fileTags, split(/,/, $tagsString, 0))); } }; } close($handle); (my(%uniqueTags) = map({myTrim($_, 1);} @fileTags)); (@allTags = (@allTags, keys(%uniqueTags))); } print(("@allTags\n"));

Hopefully, seeing myTrim($_, 1) will set alarm bells ringing because your myTrim function takes one argument, not two.

As a matter of personal style, I would write your:

my ($str) = @_;
my $str = shift; # the string to be trimmed
because I like to put a comment next to each parameter describing what it does, plus this style scales nicely for subroutines that take more than one argument (a random example of this style can be found here).

In reply to Re: Mapping list to hash is dropping list items by eyepopslikeamosquito
in thread Mapping list to hash is dropping list items by almsdealer

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?

What's my password?
Create A New User
Domain Nodelet?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others contemplating the Monastery: (4)
As of 2024-06-22 06:03 GMT
Find Nodes?
    Voting Booth?

    No recent polls found

    erzuuli‥ 🛈The London Perl and Raku Workshop takes place on 26th Oct 2024. If your company depends on Perl, please consider sponsoring and/or attending.