The first problem is that this code is a syntax error. You couldn't even compile this could you? The reason is simple:

if ($condition) { 
    #code
};   # <-------- semicolon is syntax error
elsif ($condition) {
    #code
}
[download]

I dont like this indent style much because of this type of problem.(I'm a cuddeled else man myself, I don't like 'em lonely :-) Change it to:

if ($condition) {
    #code
} elsif ($condition) {
    #code
}
[download]

Of course as suaveant said you'll also have to change your regex syntax.

foreach (@vals) {
    $SubKey->GetValues(\%cvalues);
    
      if ($cvalues{'Server'}[2] =~/NT-PRINT1/) {
         print "something\n";
      } elsif ($cvalues{'Server'}[2] =~/NT-PRINT2/) {
        print "another thing\n";
      }
    
}
[download]

HTH

Yves
--
You are not ready to use symrefs unless you already know why they are bad. -- tadmc (CLPM)

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.