You may want to apply a better scaling factor to some of these categories. At this point, it seems to me that a script which:
- uses strict
- uses -T and correctly performs taint checking
- uses CGI.pm to handle CGI form input
can score worse than a script which does none of these, but which:
- uses CGI.pm for HTML output
- uses here-docs instead of multiple print statements
- has "good" style and "effective" commenting (by some subjective standard)
Let's keep our priorities clear. Style may count for something, but I think that security and correctness should count for much more.
Update: The security issues appear to be addressed somewhat in the previous node (which beat me by bare seconds), but I think I still have a point here somewhere...
Update2: By the way, do you need and/or want help reviewing the scripts?
buckaduck
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|