Neat stuff! ++! I have to comment on some style though:
Things i don't like (sorry):
- hand rolling your own arg processor - not good if you
are handing code out to others, use Getopt::Std or
Getopt::Long instead.
- C style for loops - if i have said it once here i have
said it one thousand
times: for my $j (0..$maxchar) {} is so much
nicer.
Things i did like:
- use of Symbol
- using readline on a hash ref key to get around the
interpreter mixing up angle brackets and the arrow
operator (my $one = <$data[0]->{FH}>; doesn't
work - i would have gimped out with a temp var)
- fully qualifying $a and $b to main in your sort
Thanks!
jeffa
L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
F--F--F--F--F--F--F--F--
(the triplet paradiddle)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|