Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

I'm writing a script that has to read from a binary file. Sometimes it has to read 1 byte, sometimes 4, sometimes 12. This seems ripe for a function, so I wrote one:

sub ReadBytes { my $num = shift; return undef if $num < 1; my @bytes; for (1..$num) { my $byte; read(BINFILE, $byte, 1); push @bytes, unpack("C",$byte); } return @bytes; }

The problem I have is that while I will always be reading from BINFILE in *this* script, this sub isn't very flexible and doesn't lend itself to code re-use (and therefore offends my sense of aesthetics). Further, since BINFILE is opened within another sub (ParseData, which does interesting things to the bytes I'm reading from BINFILE), I have ReadBytes embedded in ParseData. Nested subs are icky, in my book (there's that darned sense of aesthetics again), and there must be a better way to do it.

So my question is this: Just what is the Better Way To Do It?

Update: Passing the filehandle is just what I was looking for. For some reason I thought I'd have to tie it in some way - I forgot about passing a ref to the typeglob. Thanks all for your help!

"One word of warning: if you meet a bunch of Perl programmers on the bus or something, don't look them in the eye. They've been known to try to convert the young into Perl monks." - Frank Willison

In reply to Nested subs - inherently evil? by myocom

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others wandering the Monastery: (6)
As of 2024-04-19 10:58 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found