my problem is i've already untainted this data once.
# ...snip...
# untaint parameters
for( keys %params )
{
# !!!TODO!!! check 'ref' line for subtle bugs
( display_message( $messages{error} ) && exit )
unless ref($valid_params{$_}) eq 'Regexp';
if( $params{$_} =~ /$valid_params{$_}/ )
{
$params{$_} = $1;
}
else
{
display_message( $messages{error} ) && exit;
}
}
so the data in
%params should be untainted, no? but when it's accessed later, via
my $userfile = get_userfile( $config, $params{username} );
$userfile is now tainted, even though
$params{username} should be untainted. am i missing something?
Update: modifying the get_userfile() sub like so:
sub get_userfile
{
my ( $config, $username ) = ( shift, shift );
# add only this line: still tainted
# ( $config->{ users } ) = ( $config->{ users } =~ /^(.+)$/ );
# add only this line: untainted
# ( $username ) = ( $username =~ /^(.+)$/ );
$config->{ users } . $username;
}
so
$config and its data are not tainted. why is
$params{ username } still tainted?
~Particle ;Þ
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.