Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
OK - maybe my first guess was wrong... :)

If I use "my $t" within this sub and localise it, we wont be referring to the first $t defined outside the sub.Is that right?
Yes - that's right. I thought maybe you were using $t for some other purpose, but it would appear not.

I'm not sure where we should use "my", and where we should not
Check out the section on 'scope' in whatever perl books/docs you have. 'my' declares a variable within the 'current scope' - if that's in a sub (or any pair of braces),it's gone when you exit the sub. If, on the other hand, it's in the 'main body' of your code, it's global oops - I mean file scoped...ermm..global to your file...ermm...you know what I mean - see the AM posting below... . That is generally a Bad Thing.

Turning on use strict gives no message about $t.
Does it give messages about other things? What about use warnings? Fix these, and your problem may possibly go away.

I haven't any more specific ideas, but here are a few general suggestions.

  • use strict; use warnings;
  • Don't use globals if you can help it. Pass arguments to subroutines instead - this helps your code become more 'general'
  • use strict; use warnings;
  • Refactor and tidy up. sub replace1,sub replace2 etc. look like they should be candidates for a single sub, with the replace string (and probably the text widget as well) passed in as a parameter.
  • use strict; use warnings;
  • Debug. Lots. Print out the values of $t after you initialise it, before you use it, after you use it etc. Check they're all the same type/memory address.
Hope this helps, Ben.

In reply to Re: Re: Re: Tk question by benn
in thread Tk question by perl_seeker

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (3)
As of 2024-04-19 19:10 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found