That line looks like it's doing nothing useful. Why would you have it there? Also, you return 1; from both execution paths inside the !8ball scenario. Wouldn't it be clearer to remove that from the inner blocks and leave it in the middle block?
Another suggestion would be to reverse your thought process. Instead of figuring out what you need to do to enter a block, figure out what you need to do to continue processing. Possibly done as such:
my ($eb_connection, $eb_sender, $eb_message, $eb_flags) = @_;
return unless $eb_message =~ /!8ball/;
my $answer = split(' ', $eb_message) > 1
? "You need to ask a question!"
: "The magic 8 ball says..." . $ball_messages[ rand scalar @ball_m
+essages ] . ".\n";
GAIM::serv_send_im($eb_connection, $eb_sender, $answer_message, 1);
Take code that's the same except for one variable and combine it so that the variable is assigned, not the code re-written. That improves clarity, reduces bugs, and can often provide a speed boost. (If only in the compile stage ...)
We are the carpenters and bricklayers of the Information Age.
The idea is a little like C++ templates, except not quite so brain-meltingly complicated. -- TheDamian, Exegesis 6
Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||