comment on

First, your $errorstate variable is named the opposite of what it should be. You set it to 1 when the input is formatted properly! Then, the bottom half of your code can be idiomized using some built-in variables in Perl. And are you sure you want to REMOVE the '#' from lines starting with '#port'? You also do some unnecessary work of checking to see if a regex matches before doing a substitution using that regex.

It turns out you can get rid of $errorstate altogether, and just loop until $sshport has a value.

#!/usr/bin/perl

use strict;
use warnings;

my $sshport = 0;

until ($sshport) {
  print "Please enter SSH port number> ";
  chomp($sshport = <STDIN>);
  $sshport = 0 unless $sshport =~ /^[1-9]\d{1,9}$/;
}

{
  local $^I = ".old";             # the "in-place edit backup extensio
+n" variable
  local @ARGV = ("sshd_config");  # the files to edit in-place

  while (<>) {
    s/^(#?)port .*/$1Port $sshport/i;
    # this KEEPS the '#' character,
    # which I think is the correct behavior
  }
}
[download]

See perlvar for information about $^I.

Jeff japhy Pinyan, P.L., P.M., P.O.D, X.S.: Perl, regex, and perl hacker
How can we ever be the sold short or the cheated, we who for every service have long ago been overpaid? ~~ Meister Eckhart

In reply to Re: Defactor this code by japhy
in thread Defactor this code by xerophyte

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Do you know where your variables are?
	PerlMonks