I second the idea of whitelisting the acceptable values for $SPROC and also using placeholders to insert the elements of @CHOICE into the SQL.
Combining the two ideas, might give something like this:
# %procs contains the names of the valid stored procs
# together with the number of parameters each requires
my %procs = (
proc1 => 2,
proc2 => 0,
proc3 => 1,
# ...
);
unless (exists $procs{$SPROC}) {
die "Unknown stored proc: $SPROC\n";
}
my $sql = "EXEC $SPROC ".
join ', ', ('?') x $procs{$SPROC};
my $sth = $dbh->prepare($sql);
$sth->execute(@CHOICE);
This code also has the advantage of dieing if the number of elements in @CHOICE doesn't match the expected number of parameters.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|