Re: Opening and closing files in loop

Is there a restriction in opening and closing files inside a loop?

You aren't opening the files within the loop.

select only makes a particular, already open, filehandle the default for print.

But you are closeing those handles on the first pass, and they never get re-opened.

Two possibilities:

Don't close the files, just select between then:

    for ($i=1;$i<=$max;$i++){ 
       
         $pwd = &randomPwd($nmbchars);
         select (DB);
         print qq("$dept$w$i","7 days","$pwd",,,,,,\n);

         select (newDB);
         print qq("$dept$w$i"\t>\t"$pwd"\n);

     }
[download]

Instead of selecting between them, supply the required file handle to the print statements:

    for ($i=1;$i<=$max;$i++){ 
       
         $pwd = &randomPwd($nmbchars);

         print DB qq("$dept$w$i","7 days","$pwd",,,,,,\n);

         print newDB qq("$dept$w$i"\t>\t"$pwd"\n);

     }
[download]

Personally, I prefer the latter option.

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.

"Science is about questioning the status quo. Questioning authority".

In the absence of evidence, opinion is indistinguishable from prejudice.

RIP Neil Armstrong

Comment on Re: Opening and closing files in loop Select or Download Code

Replies are listed 'Best First'.

Re^2: Opening and closing files in loop
by lt007 (Initiate) on Oct 22, 2012 at 08:42 UTC

Thank you very much!!

[reply]


XP is just a number
	PerlMonks