Re: Smartphone/Media Center integration via XMPP over GoogleTalk

[jwkrahn]

    foreach my $tmp_name (`dcop amarok playlist filenames`) {

        $tmp_string .= "[$tmp_idx]\t";   

        # remove common suffixes
        chomp $tmp_name;
        for my $suffix ( '.mp3', '.flac', '.shn', '.ogg' ) {
            $tmp_name =~ s/$suffix$//;
        }

        # and append the filename
        $tmp_string .= 
          ( $playing =~ /$tmp_name/ ) ? "*** $tmp_name ***\n" : "$tmp_
+name\n";

        $tmp_idx++;
    }

Your algorithm is broken, see for example:

$ perl -e'
    my @files = ( "egg_nogg.mp3\n", "egg_nogg\n", "stupid file.ogg.shn
+.flac.mp3\n", "stupid fileloggashnoflacamp3\n" );

    foreach my $tmp_name ( @files  ) {
        print "\$tmp_name = $tmp_name\t=>";
        # remove common suffixes
        chomp $tmp_name;
        for my $suffix ( ".mp3", ".flac", ".shn", ".ogg" ) {
            $tmp_name =~ s/$suffix$//;
        }
        print "\t$tmp_name\n";
    }

'
$tmp_name = egg_nogg.mp3
        =>      egg_
$tmp_name = egg_nogg
        =>      egg_
$tmp_name = stupid file.ogg.shn.flac.mp3
        =>      stupid file
$tmp_name = stupid fileloggashnoflacamp3
        =>      stupid file

That would be better written as:

    foreach my $tmp_name (`dcop amarok playlist filenames`) {

        $tmp_string .= "[$tmp_idx]\t";   

        # remove common suffixes
        chomp $tmp_name;
        $tmp_name =~ s/\.(?:mp3|flac|shn|ogg)\z//;

        # and append the filename
        $tmp_string .= 
          ( $playing =~ /$tmp_name/ ) ? "*** $tmp_name ***\n" : "$tmp_
+name\n";

        $tmp_idx++;
    }

[mikelieman]

Thanks for the tip. Luckily, that broken algorithm is just used to produce pretty printed output for displaying playlists. I'll make sure to include the changes into the next revision however.

[mikelieman]

The one-line bug has been patched in the code.