jonesd14:
The first half is pretty good. There are a few quibbles, but nothing bad. For the second half, though, you're doing *far* too much work to get the best key/value from the hash. I'dd suggest something more like this:
my ($bestVal, $bestKey) = (-1);
foreach my $key (@keys) {
if ($hash{$key} > $bestVal) {
($bestVal, $bestKey) = ($hash{$key}, $key);
}
}
print "The most frequent word in $ARGV[0] is $bestKey, which was seen
+$bestVal times.\n";
Now on to a few of the quibbles:
I didn't see any real problems, just unnecessary work. Nice work!
Update: Updated first quibble.
...roboticus
When your only tool is a hammer, all problems look like your thumb. k
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|