Simply for the laziness of using
List::Util. But if you're gonna optimize it, why check both conditions? An element can't be the maximum and the minimum at the same time. You're also pulling the list of all keys twice.
my ($min, $max) = (scalar each %h) x 2;
($min, $max) = (
$h{$_} < $h{$min} ? ($_, $max) :
$h{$_} > $h{$max} ? ($min, $_) :
($min, $max)
) for keys %h;
You could even go all out on
each to remove the last bit of redundant work, and to reduce memory footprint.
my $min = each %h;
my $max = each %h;
if(defined $max) {
local $_;
($min, $max) = (
$h{$_} < $h{$min} ? ($_, $max) :
$h{$_} > $h{$max} ? ($min, $_) :
($min, $max)
) while defined($_ = each %h);
}
else {
$max = $min;
}
That's all cool if your hash is really huge. If it's just a couple pairs, I'll prefer the lazy route any day.
Makeshifts last the longest.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.