Ouch, did you just change $" and pass that
change on to DBI? What say you localize that a bit more
local. =)
my $sql;
{
my @values = ('?') x @columns; # I love that, BTW...
local $" = ',';
$sql = "INSERT INTO $table (@columns) VALUES (@values)";
}
$dbh->prepare($sql) or die("Couldn't prepare $sql " . $dbh->errstr);
Sure, the likelyhood of any of the DBI/DBD stuff using a
string-interpolated array is pretty low but it is still bad
practice.
--
$you = new YOU;
honk() if $you->love(perl)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|