I'd probably do this:
#!/usr/bin/perl
use strict;
use warnings;
open( NAMES, "<", "name.txt") or die $!;
my @list = <NAMES>;
close(NAMES);
print "list = @list\n";
for my $name (@list) {
open(OUT, ">", $name) or die $!;
print OUT "hello";
close(OUT);
}
Notice the differences:
1. use strict and use warnings;
2. use the "$!" so you get the explicit error when there is one
3. you didn't define $y - and it looks to be unnecessary for this
4. you didn't close the FILE handles
5. you need to specify the FILE handle you want to write to
Start with "use strict" and "use warnings" and that will be very helpful!
hth,
dave
Update: Oops, forgot the .txt part - see madtoperl's node.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|