Dear Monks,

I have also tried to avoid the use of map because I really can never understand what it is doing therefore assume that other people that might have to read my code might also find it difficult to understand if they ever had to maintain it.

Unfortunately I am the one maintaining the code of some really smart guy that thinks map, and unlesses and other crappy obfuscations make for maintainable code. Please forgive my rant ... anyways here's the bit of code I would to un map so I can add some debug to it.

sub _file_containing {
    my($self, $id) = @_;

    opendir(my $dir, $self->{update_dir}) or return;
    my @files =
      map { "$self->{update_dir}/$_" }
        sort { $a <=> $b }
          grep { /^\d+$/ && $_ <= $id }
            readdir $dir;
    return $files[-1];
}
[download]

Oh here's some more ranting ... sorry

I understand that back in the day structured programming it was a good idea to put an '_' in front of function if you where writing libraries so you wouldn't clutter the namespace of people using your libraries. But when I see it in circumstances like object orientated code is being used this practice of _my_great_subroutine only points out the pretensiousness of the doofus that wrote the code!

Thank you and I apologize for the rants.