sub updateTiles { 
        my $fto = $htmDir . 'tile.htm'; 
## global var used

        my $content = ''; 
        open(HOME,$fto); 
## no checking for return value, could have redirect or pipe opens

        while (<HOME>) { $content .= $_ } 
## inefficient

        close(HOME); 
        my $paramTemp,$contentTemp; 
## $contentTemp is NOT BEING DECLARED LOCAL (very misleading)

        my @sections = qw(Tile Pile Link); 
        foreach $section (@sections) { 
## no declaration of $section

                $contentTemp = $query->param($section); 
## use of global $query.  Why is contentTemp not declared here?

                if ($section eq 'Pile') { $contentTemp =~ s/[\n\r]/<p>
+/g; } 
                if ($section eq 'Link') { $contentTemp = "<img src=\"i
+mages/enter.gif\" width=8 height=12><a href=\"cgi-bin/show.cgi?action
+=showTiles&tileType=Search&searchFor=$contentTemp\">View this month's
+ tiles.</a>" } 
## ampersands not entitized,  inserted content not entitized or escape
+d

                $content =~ s/<!--$section-->(.*)/<!--$section-->$cont
+entTemp/; 
## parens not needed on .*, what if $section has regex chars?

        } 
        open(HOME,">$fto"); 
## no checking return values; what if $fto starts with >?

        print HOME $content; 
## could get IO error.  What if visitor hits page while partially writ
+ten?

        close(HOME); 
## could get IO error.

        my $image = $query->param('Image'); 
        if ($image ne '') { my $newFile = fileUpload('Image',250000,1,
+'latest_image','JPEG','.jpg','.jpeg') } 
## image might be undef if param not provided.

}
[download]

See what you can get for $10 of my time? How many of those would you have found for $10 of your time? {grin}

-- Randal L. Schwartz, Perl hacker