Re^3: Stupid mistakes I repeatedly make

[Tanktalus]

Just to follow this thread off-topic ... how often does it matter? I can't even think of any time where I cared how many items were replaced with s///. And it's almost never when I don't care about the resultant string. So, yes, I'd agree that PHP's method is as flexible as Perl's, but I would suggest that the s operator is not Huffman-coded properly. The thing that we do most often (care about the resultant string) is the most work. Even if the difference is minor (an extra set of parens), Larry seems to talk a lot about "natural language" for perl 6, and I'd suggest that the current syntax is less natural. If, for example, s/// returned the resultant string in scalar context and the list of substitutions in list context, you could get the number of substitutions with my $num = @{[s/$re/foo/g]}; (although that syntax is probably not so ugly in perl 6 either). Given the rareness of its use (if my experience is any indication, or even in the same ballpark as reality in general), I think this would make more sense.

I seem to recall that perl6 is supposed to solve all of this, so not only is this thread off-topic, but probably moot anyway ;-)

[itub]

I've often seen code that, although it doesn't care about the exact number of replacements, it cares about whether a replacement was made (the number would be 0 or 1 since it's not a global replacement). This is typically used for tokenizing by deleting the tokens from a string (note: this might not very efficient for long strings!). The following is a simple example for tokenizing a space-delimited list of numbers.

$s = "213 3218 213";
while ($s =~ s/^(\d+)\s*//) {
  print "$1\n";
}
if (length $s) {
  print "Error! didn't expect this: '$s'\n";
}

This contrived example could probably be done more simply in other ways, but for more complicated tokenizers it is not such a bad approach.

[Tanktalus]

I stand corrected. Thanks, itub and Roy Johnson. Normally I do this in two phases (the match, then the substitution), but that's just me, and not something to advocate as the One True Perl Way. :-) I just find it makes more sense, but largely because I forget about s returning the number of matches, which is largely due to lack of need (usually I do the substitution and continue without any branching on whether it was succesful or not).

[Roy Johnson]

You likely don't care how many times the replacement happened, but it's not uncommon to care about whether any replacements happened.

if (s/foo/bar/) {
  ...
}
else { 
  ...
}

(How many isn't even an issue unless you're using /g. It's just 1 or 0 — it replaced something or it didn't.)

[Ven'Tatsu]

I've use this in my code before:

#actual data came over the network with inconstant line ends.
my $text = "some\r\nmulti-line\ntext";
my $line_count = $text =~ s/\r?\n/\n/g;

There were cenrtanly a dozen other ways to get the line count, but for what was being done this was the most strait forward, without doing double work.