Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re: ?: = Obfuscation?

by Tanktalus (Canon)
on Dec 01, 2006 at 19:30 UTC ( #587274=note: print w/replies, xml ) Need Help??

in reply to ?: = Obfuscation?

I think you're tallying me in that "couple and half" so I'd like to clarify. I didn't say the ?: operator is always less readable than an if/else block. I only meant that the ?: operator is less readable than an if/else block when you're doing two different things, especially to two different variables. $y = $x ? 1 : 0 is fine. But if you're trying to set one of $y or $z based on $x, well, just saying that is complicated. The code should always reflect the (human) thought process that it is describing - a little extra verbosity in the code to reflect extra spoken verbosity is a good thing. (Please don't take that to extremes. I'm not advocating useless extra code here.)

As far as understanding it - yes, I expect my junior coworkers to understand it. Just not abuse it. Perl, like English, has a natural flow to it. If you try to say something with an unnatural grammar, people may understand it even though it may jar their ears to hear it. Similarly, perl's natural flow can be disrupted and the code still works.

If your code follows the natural flow of the language, the listener (maintainer) who comes along will be able to just read your code. When you do tricky things, you disrupt the maintainer's flow, and they'll need to do a double-take to figure out what really is going on there. If that isn't the problem area, they just wasted time deciphering something that turned out to be irrelevant. And that just annoys us maintainers ;-)

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://587274]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (8)
As of 2018-06-18 10:21 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (109 votes). Check out past polls.