Re: Perl::Tidy formatting question

[vendion]

I also have a question on Perl::Tidy's formatting, one complaint I have is the new line for else statements. So a if/else statement that looks like this:

if ( $foo eq 'bar' ) {
    # Do something
} else {
    # Do something else
}

Which in my option is perfectly readable becomes this once ran through Perl::Tidy:

if ( $foo eq 'bar' ) {
    # Do something
}
else {
    # Do something else
}

I don't quite get the reason for breaking the else statement in such a way and if there is a way to tell it not to do such, I may have over looked it when reading through the man for it, please let me know. Also if there is some really good reason why Perl::Tidy would default to doing this that is considered best practice and doesn't cause Perl::Critic on its most brutal setting to complain about it please enlighten me.

[toolic]

if there is a way to tell it not to do such, I may have over looked it when reading through the man for it, please let me know

You want "cuddled else" (-ce):

perltidy -ce script.pl

The Perl Best Practices book recommends: "Don't cuddle an else". You need to buy the book if you want to know the reason. Perhaps perltidy adheres to this as its default behavior.

[vendion]

I do have the PBP I guess I have not run across that before, what is even weirder is Perl::Critic doesn't say anything under Brutal mode and that basically "throws the book at you". Anyways thanks for the pointer and I'll have to search for the section of the PBP later today for why that is recommended.

[toolic]

Perl::Critic doesn't say anything under Brutal mode

By default, perlcritic runs perltidy (see Perl::Critic::Policy::CodeLayout::RequireTidyCode). So, it will tell you that your code is untidy if you configure perltidy to complain about cuddled elses.