Re: Accessing module variables

[Eily]

The credentials are stored like this so that the processing scripts can be checked into github without credentials leaving the customer site.

"like this" meaning? In separate files, in .pm files, in exported package scalars? Depending on how much you can change, it might be easier to store the values in a hash in the first place:

our @Export = ( %credentials );
our %credentials = ( User => 'Joe', Password => 'Secret123' ...);
# or: (User => $User, Password => $Password ...); if you want to still
+ define the scalars

Or even better, store them as proper configuration files with whatever format you want.

It looks like your modules are supposed to export all their variables (although you used @Export rather than @EXPORT). If that's the case, you should use require rather than use, so that you don't import each time and overwrite the $User, $Password... in your calling package.

[hippo]

If that's the case, you should use require rather than use, so that you don't import each time and overwrite the $User, $Password... in your calling package.

Or else leverage this to your advantage, import them each time through the loop and just refer to them by their local symbol names.

Although I agree that it would be better not to start from here and go with config files instead.

[talexb]

It looks like your modules are supposed to export all their variables (although you used @Export rather than @EXPORT) ..

Oh dear. What a rookie mistake. Yes, I think I meant to use EXPORT.

In any case, clearly the credentials should be stored in configuration files and not modules .. that would make it easier for external control .. these processes are currently being handled by a crontab setup, which works well, but isn't ideal.

Thanks for the feedback!