Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

I skipped the bit where you set up the names of input file and output file. But generally speaking, you should always always 'use strict;' and 'use warnings;'. They really are the very best ways to stop a program doing anything weird.

And as mentioned above- a while look is better than a foreach if you're processing a large file. (Makes little odds for a small file, but it's good form).

Perl is very clever - it understand context. <$input_fh> says 'read from $input_fh' but if you do:

my $line = <$input_fh>;

it simply reads the next line. Where if you do

my @whole_file = <$input_fh>;

It will read the whole file into that array - which is in effect what my first snippet does. It doesn't make much difference if you're working with a small file, but the difference will become very important with a 500MB file.

I'd strongly suggest taking time to understand what each line is doing - code that someone on the internet gave you is never trustworthy. (Although on Perlmonks, usually true evil will get stomped upon)


In reply to Re^5: Shorten the headers of a file and remove empty lines using perl by Preceptor
in thread Shorten the headers of a file and remove empty lines using perl by intect

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others taking refuge in the Monastery: (2)
As of 2024-04-26 01:38 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found