Re: system command with arguments Error

[blue_cowdawg]

boo hiss! I hate seeing one Perl script calling another. Sloppy...

What might help you out is to do one of two things in descending levels of difficulty:

• Convert the functionality of Cart.pl to a module
• Convert the functionality of Cart.pl to a sub

In the first case you'd have to take the time to examine what Cart.pl does and write a module for it that does the same thing. Not quite as easy as just doing

$   cp Cart.pl Cart.pm

you'd actually have to wrap the logic in some fashion that makes sense. For instance, here's a small Perl script I want to convert.

#!/usr/bin/perl -w 
use strict;

#
# This is the main part of the script here...

my ($parm1,$parm2,$parm3,$parm4)=@ARGV;

func1($parm1,$parm2)
$func2($parm3,$parm4)

exit(0);

sub func1{
#logic here.
}
sub func2{
#logic here
}
|
| etc
|

which could become:

package Cart;

sub new {
   shift;
   my $self={};

   bless $self,"Cart";
   return $self;
}

sub doCart { 
     my ($self,$parm1,$parm2,$parm3,$parm4)=@_;

     # main part of original script goes here
}

sub func1{
}
sub func2{
}

1;

You could then invoke it as:

#!/usr/bin/perl -w 
use strict;
use lib qw @ /path/to/directory/my/binary/runs/from @;
use Cart;

my $cart = new Cart();
|
| hand waving
|
$cart->doCart($arg1,$arg2,$arrg3,$arrr_ahoy_matey);
|
| etcetera...
|

the important part is the use lib part which causes Perl to look for your module where it lives. In this case I'm saying the same place the script lives. You could also do

use FindBin qw/ $Bin /;
use lib "$Bin";
| etc

[ansh batra]

thankyou for the explaination blue_cowdawg

[tbone654]

I was just wondering if it's in the same directory, maybe the permissions are not sufficient, and you should source the file?




#!/usr/bin/perl
use strict;
use warnings;


print system (qw/.\/runssh_bro.pl 10.77.77.77 filename1.out/);
print system (qw/.\/runssh_bro.pl 10.77.77.77 filename2.out/);