Hi tomdee27,

if you were formatting your code correctly (i.e. with consistent indentation), you would probably see your mistake.

Both indentation styles shown below, used consistently, show clearly that you have a spurious extra closing curly at the end:

if ($tempdesc >= 55) {      
    if ($tempdesc2 =~ /electric/) {
        print FH_OUTFILE "\n";
    } else {
        print FH_OUTFILE "free_batteries\n";
    }
} else {
    print FH_OUTFILE "\n";
}
}
[download]

And:

if ($tempdesc >= 55)
{      
    if ($tempdesc2 =~ /electric/) 
    {
        print FH_OUTFILE "\n";
    } else 
    {
        print FH_OUTFILE "free_batteries\n";
    }
} else 
{
    print FH_OUTFILE "\n";
}
}
[download]

Even though the compiler does not care about correct (consistent) indentation, human readers do. And that includes myself, other monks around here and, last but not least, YOU. The careless formatting of the code in your original post prevents you from seeing your error.

Taking the time to carefully and consistently indent your code (using whichever indenting style you may want to choose) is never a waste of time, and it is most of the time a great time saver. Indentation may not be needed by the compiler, but it is not optional, it is essential for the human reader (you in the first place).

You're obviously a beginner and may not have figured out this point until now, but, please, please, take right now the good habit for formatting correctly your code.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.