A few random suggestions after skimming your code:
- Prefer lower case for variable names (your code looks like it's shouting).
- Learn Perl here documents.
- Spend more time choosing good names (descriptive, explanatory, consistent, regular, ... spelt-correctly ;-).
- Your main program is way too long. Decompose it into modules. Write unit tests for each module. Avoid big-arse functions.
- Run your script through Perl::Critic.
- Prefer three-argument open.
- Insert $! in your error strings when a Perl function fails.
- Prefer low precedence or to ||; for example, prefer or die to || die.
- Don't use a leading & when calling functions.
- Avoid C-style for loops. For example, prefer for my $item (@arr) {...$item...} to for(my $I=0;$I<@ARR;$I++) {...$ARR[$I]...}.
- Prefer my variables to our variables. Declare variables at point of first use (do not declare a huge bunch of variables at the top of a subroutine). Minimize variable scope. Avoid global variables.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
