I wouldn't recommend using that script verbatim. Feeding user input to system() is a bad thing, and feeding it in scalar context is extra bad. Using system() with a scalar rather than an array argument sends the command to the system shell (usually /bin/sh) for processing, so metacharacters like ';' and '`' get interpreted. Anyone who finds the script can run arbitrary commands as you simply by putting them in the 'module' parameter. E.g. if someone loads http://someisp.com/~you/compile.cgi?module=;rm%20-rf%20*;, that script would happily run system("/bin/gunzip ;rm -rf *;.tar.gz")
-Matt
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|