Hi hilitai,
Your module is very readable; nice job!
I particularly like your use of pod, intermixed with the code in such a way that each subroutine is documented by the corresponding pod block. (It may be a more common technique than I'm aware, but I haven't seen it before).
Here are a couple of minor suggestions, all related to open:
- You might consider using lexically-scoped filehandles, via FileHandle or IO::File. Using IN runs the risk of stomping on a globally-defined IN from somewhere else (eg. the calling program). (Same with EXP).
- You don't need quotation marks around $basefile in open(IN, "$basefile"). (Same with $expFile).
- Why not use the 3-argument form of open?
s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|