Re: File::Find Question

[jkeenan1]

Your code is in severe need of simplification and cleanup before we can consider whether using File::Find would improve it.

For example, write off the bat I detected three variables which are declared but never used:

$size
$name
$SDIR

Get rid of them -- and while you're removing them, also delete all the commented-out code, which only serves as a distraction to those reading your post and trying to help you.

Next, note that on line 56 you assign $drive to $dirlist[0], and then within five lines you call for a loop over the contents of @dirlist. If you only have one entry in the list over which you are iterating, you can ditch the for loop as well.

Thank you very much.

[RockE]

Thanks for your reply Jim I've cleaned it up as requested. $drive is usually a CD drive, there is always more than one file